Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(locators): do not escape regular expressions with u or v flag #27188

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix(locators): do not escape regular expressions with u or v flag #27188

merged 1 commit into from
Sep 19, 2023

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Sep 19, 2023 •
edited
Loading

Fixes #27163.

@dgozman dgozman changed the title fix(locators): do not escape regular expressions with u flag fix(locators): do not escape regular expressions with u or v flag Sep 19, 2023
@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › playwright.spec.ts:493:5 › should work with video: on-first-retry

10 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › page/page-event-request.spec.ts:162:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › page/page-goto.spec.ts:266:3 › should fail when navigating to bad SSL
⚠️ [webkit] › page/page-goto.spec.ts:277:3 › should fail when navigating to bad SSL after redirects
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:167:5 › should update tracing network live

25654 passed, 604 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit bb4268d into microsoft:main Sep 19, 2023
dgozman added a commit to dgozman/playwright that referenced this pull request Sep 19, 2023
@dgozman
cherry-pick(microsoft#27188): fix(locators): do not escape regular ex…
62c66cd 
…pressions with u or v flag

Fixes microsoft#27163.
dgozman added a commit that referenced this pull request Sep 19, 2023
@dgozman
cherry-pick(#27188): fix(locators): do not escape regular expressions…
abf9df3 
… with u or v flag (#27190)

Fixes #27163.
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
@dgozman @Germandrummer92
fix(locators): do not escape regular expressions with u or v flag (mi…
3f1fb37 
…crosoft#27188)

Fixes microsoft#27163.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REGRESSION] Single Quote Wrongly Escaped by Locator When Using Unicode Flag
2 participants
@dgozman @yury-s